Split install and configure commands #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
========================================
- Coverage 98.3% 98.1% -0.2%
========================================
Files 8 8
Lines 357 381 +24
========================================
+ Hits 351 374 +23
- Misses 6 7 +1
|
r-b-g-b
reviewed
Jul 10, 2020
| @@ -44,10 +46,18 @@ def main( | |||
| help="Show nbautoexport version.", | |||
| ), | |||
| ): | |||
| """Exports Jupyter notebooks to various file formats (.py, .html, and more) upon save, | |||
| automatically. | |||
| """Automatically export Jupyter notebooks to various file formats (.py, .html, and more) upon | |||
There was a problem hiding this comment.
Ah just noticing that typer very nicely adjusts the width of these docstrings when they are printed out in the command line. Now the docstrings can be written with column width of 100 in the source code, but printed out to column width of 80 for the 0.1% of ppl who use ancient monitors.
There was a problem hiding this comment.
Yeah, this actually annoyed me recently for a different project where I wanted to put some ASCII art in my help string but typer totally destroyed it with formatting. 😂 😢
r-b-g-b
requested changes
Jul 10, 2020
|
@r-b-g-b I think the issue you had should be fixed. Ready for another look. |
r-b-g-b
approved these changes
Jul 10, 2020
|
|
||
|
|
||
| def test_configure_no_jupyter_config_warning(tmp_path, monkeypatch): | ||
| monkeypatch.setenv("JUPYTER_CONFIG_DIR", str(tmp_path)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting
installcommandinstallinto two commands:installinstalls the post-save hook initialization in the Jupyter configconfigurecreates the.nbautoexportconfiguration file in a directoryconfigurecommand, if the post-save hook initialization is absent or out-of-date, there will be a warning printed.--jupyter-configoption toinstallif user wants to install the post-save hook initialization to a Jupyter config in a nonstandard location.Other
cleanconfiguration option was not being passed throughinstall_sentinel. Fixed by changing the interface ofinstall_sentinelto accept a config object instead specifying each option. This reduces likelihood of similar future bugs by reducing the number of places that reproduce theNbAutoexportConfiginterface.pkg_resources.parse_versionwithpackaging.version.parse. This is whatpkg_resourcescalls under the hood and is a lighter-weight dependency..codecovconfiguration to:reachgraph, which I never found that interpretable but is really visually obnoxious.Closes #34. I did not unify the naming and opened #37 separately to avoid adding noise to this PR's diff.