setup.py cleanup and mypy #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
======================================
Coverage 98.1% 98.1%
======================================
Files 8 8
Lines 371 371
======================================
Hits 364 364
Misses 7 7
|
| name="nbautoexport", | ||
| packages=find_packages(include=["nbautoexport", "nbautoexport.*"]), | ||
| setup_requires=setup_requirements, | ||
| test_suite="tests", | ||
| tests_require=test_requirements, |
There was a problem hiding this comment.
Just for my own learning, why don't we need lines 60-62?
There was a problem hiding this comment.
https://setuptools.readthedocs.io/en/latest/setuptools.html This page from the setuptools docs is where this stuff is described.
setup_requires has a red warning box that says it's discouraged in favor of the PEP-517/PEP-518 new system using pyproject.toml that we ran into with sample-weights. We also don't need it for this package, because we don't have any special build-time dependencies.
test_suite and tests_require are both for if we run our tests with python setup.py tests. We don't run our tests that way anyways, and "New in 41.5.0: Deprecated the test command" is everywhere in the setuptools docs that has anything to do with running tests.
.travis.yml