Added setTimeout for XMLHttpRequest #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need the timeout feature, but we need an interface more similar than the W3C standard. Is it possible to change your implementation to comply (at least at interface level) with the standard? |
|
@ortegag can you give an example of something "more similar than the W3C standard" |
|
I've seen two separate instances of this issue crop up. +1 |
|
@driverdan Can you let us know what's stopping you from accepting this PR? Any doubts or qualms you have about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to set request timeout in our production to avoid blocking too many requests.I added a method
setTimeoutfor XMLHttpRequest.I hope it can be merged into master branch,then i don't have to use my own version ofnode-XMLHttpRequest.Thanks for your great work.