Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix typos in joins.md #541

Merged
merged 1 commit into from
May 4, 2023
Merged

[DOCS] Fix typos in joins.md #541

merged 1 commit into from
May 4, 2023

Conversation

emdede
Copy link
Contributor

@emdede emdede commented May 2, 2023

I just went through this document a few days ago and found it a bit confusing being new to drizzle. I went ahead and cleared up the confusing parts, which seem to be mostly code relics from earlier versions.

Replaced fields() with select()
Clarified key naming without select() argument
Aggregation example was incorrectly using cityId

Copy link
Contributor

@dankochetov dankochetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@dankochetov dankochetov merged commit b3a96bc into drizzle-team:main May 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants