Cleanup: use existing local variable #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,7 +179,7 @@ class LazyXMLParser: NSObject, SimpleXmlParser, NSXMLParserDelegate { | |||
| current.text = "" | |||
| } | |||
|
|
|||
| parentStack.top().text! += string | |||
| current.text += string | |||
There was a problem hiding this comment.
Should be current.text! += string instead of current.text += string.
SWXMLHash/Source/SWXMLHash.swift:182:22: binary operator '+=' cannot be applied to operands of type 'String?' and 'String'
current.text += string
^
|
See my comments. Also, it would be a good idea to change line 244 to use |
drmohundro
changed the title
|
@drmohundro thanks for the feedback! Done :) |
drmohundro
added a commit
that referenced
this pull request
Sep 28, 2015
Cleanup: use existing local variable
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't run unit tests because Carthage installation fails on 10.11 using brew. But the change is straightforward and shouldn't cause any problems.