Migrate toolbox to mui v5 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks promising, thanks for this! Can't wait to get this merged but take your time 🤗 |
|
@drodil could I have a review please :) |
|
Thanks, looks good! Could you squash the commits a bit? These don't really follow conventional commit messages and there's a lot of WIP commits. |
|
@drodil took a while but how do you feel about this? |
|
Thanks a lot! I will take a closer look tomorrow 👌 |
drodil
approved these changes
Apr 12, 2024
|
Thanks once again! If you want to contribute more, I have another plugin with issue to update MUI to v5 as well: drodil/backstage-plugin-qeta#143 No pressure but if you want, I am up for all contributions, thanks! |
|
Thanks for the offer! However, I can't contribute to this plugin at the moment 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR migrates the tool to mui v5. The toolbox will look a little different in terms of styling here and there.
I tried to look through everything in both light and dark modes to make sure everything is in order. I could've missed some things. The changes also use some colours like #E0E0E0 that I couldn't pick up from the theme. It would be nice if you could find alternatives to hardcoded colours.