Missing Error Check in function SSL_CTX_use_certificate()

[lc3412]

Function SSL_CTX_use_certificate() returns 1 on success. Otherwise need to check out the error stack to find out the reason. However , the return value of function SSL_CTX_use_certificate() is not checked on line 769. See the following code:

line: 769

sslsplit/pxyconn.c

Lines 769 to 775 in 19a16bd

	SSL_CTX_use_certificate(sslctx, crt);
	SSL_CTX_use_PrivateKey(sslctx, key);
	for (int i = 0; i < sk_X509_num(chain); i++) {
	X509 *c = sk_X509_value(chain, i);
	ssl_x509_refcount_inc(c); /* next call consumes a reference */
	SSL_CTX_add_extra_chain_cert(sslctx, c);
	}

==================================================================================

We find the return value of this call been checked in the same file
Such as,
line: 1146

sslsplit/pxyconn.c

Lines 1146 to 1147 in 19a16bd

	if (!SSL_CTX_use_certificate(sslctx, ctx->opts->clientcrt))
	log_dbg_printf("loading client certificate failed");

Chi Li, Zuxing Gu, Jiecheng Wu

[sonertari]

Also in ssl.c on line 1269. SSL_CTX_use_certificate() is declared with __warn_unused_result__ attribute, but interestingly compilers do not give any warning.

[droe]

Thank you for reporting this issue.