Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metrics #208

Merged
merged 17 commits into from
Jan 20, 2022
Merged

Add support for metrics #208

merged 17 commits into from
Jan 20, 2022

Conversation

dejanb
Copy link
Member

@dejanb dejanb commented Jan 11, 2022

Add metrics for cloud components based on Prometheus/Grafana.
It works in combination with drogue-iot/drogue-cloud-helm-charts#12

This PR adds basics for drogue cloud monitoring, by:

  • adding drogue-cloud-metrics chart and option to install it
  • instrumenting for now http and mqtt endpoint with basic metrics

There's a new docs page with some explanations:
docs/modules/deployment/pages/monitoring.adoc
which should help with testing the PR.
Short term TODO item is to bump actix-web-prom version once the nlopes/actix-web-prom#61 is merged.

@dejanb dejanb force-pushed the metrics branch 2 times, most recently from 9136cd4 to a7d00e4 Compare January 19, 2022 09:34
@dejanb dejanb marked this pull request as ready for review January 19, 2022 16:39
@dejanb dejanb changed the title Metrics Add support for metrics Jan 19, 2022
@ctron
Copy link
Member

ctron commented Jan 20, 2022

/test

@drogue-bot
Copy link

Aye, aye, captain! … Triggered System Test worklow!

@drogue-bot
Copy link

Total Passed Failed Ignored Filtered Duration
147 147 0 0 0 34m 24s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/metrics

Commit: 1afa2185ee43c4b17d500468943211a3a70e50b9
Author: Dejan Bosanac <dejan@sensatic.net>
Date: Wed, 19 Jan 2022 15:38:00 -0100

    Merge fixes and code cleanup

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/1722290648

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/01/20/test-run-1722290648.html

@ctron ctron merged commit 0173c78 into main Jan 20, 2022
@ctron ctron deleted the metrics branch January 20, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants