Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typo regards to sha checksumming #8

Merged
merged 2 commits into from
Sep 25, 2018
Merged

fixed typo regards to sha checksumming #8

merged 2 commits into from
Sep 25, 2018

Conversation

patrickjahns
Copy link
Contributor

While testing the plugin internally - I spotted this typo - this PR should fix it

techknowlogick
techknowlogick approved these changes Sep 25, 2018
View reviewed changes
Copy link

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should a fallback be added in case there are users who are using the incorrect option?

tboerger
tboerger reviewed Sep 25, 2018
View reviewed changes
main.go Outdated Show resolved Hide resolved
@tboerger tboerger merged commit ce7e9cd into drone-plugins:master Sep 25, 2018
@tboerger
Copy link
Contributor

Pushed v1.2.1

@patrickjahns patrickjahns deleted the fix_checksumming branch September 25, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboerger tboerger tboerger approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickjahns @tboerger @techknowlogick