Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for ingress > 1.22 #50

Closed
wants to merge 1 commit into from

Conversation

devfaz
Copy link

@devfaz devfaz commented Oct 31, 2021

Just some changes to add support for ingress since kubernetes 1.22.
This includes a new value - IngressClassName to define the new field.

Also bumped version to latest available.

Copy link

@peteriselksnis peteriselksnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 1.22 work

@dhalturin
Copy link

@peteriselksnis hello, how soon will be merged?

@stv0g
Copy link

stv0g commented Mar 1, 2022

Please merge this

Copy link

@matthewhartstonge matthewhartstonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is becoming quite time critical now that kube@v1.21 is going to become End of Life on 2022-06-28. Most people are already shifting their clusters to kube@v1.22, if not kube@v1.23.

@jimsheldon
Copy link
Collaborator

Apologies for the delay on this.

#53 has been merged which should now support ingress on recent versions of kubernetes. Please test out the most recent version of this chart and open an issue if you find any problems.

I will close this out.

@jimsheldon jimsheldon closed this May 2, 2022
@devfaz devfaz deleted the fix_ingress_1_22 branch April 16, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants