drone chart updates #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to the latest version of the drone docker image, 2.11.1 - use /healthz for livenessProbe and add readinessProbe - update the chart to be compatibile with newer versions of kubernetes that require `pathType` for each specified path in an ingress - update templates/NOTES.txt and templates/ingress.yaml based on files generated by running `helm create drone` with helm version 3.8.2
Closed
pauvos
reviewed
May 1, 2022
charts/drone/values.yaml
Outdated
| @@ -48,7 +48,8 @@ ingress: | |||
| hosts: | |||
| - host: chart-example.local | |||
| paths: | |||
| - "/" | |||
| - path: "/*" | |||
There was a problem hiding this comment.
I think wildcards are not supported in ingress paths. At least they don't work with my traefik ingress controller and the kubernetes documentation doesn't seem to mention them.
- path: /
pathType: Prefix... should basically do the same thing and a lot of charts use it as suggested setting.
Everything else works fine (k3s v1.22.7)! Thanks for updating the chart, @jimsheldon 💯 🥇
There was a problem hiding this comment.
Thanks for the feedback @pauvos! I'm not sure what documentation I was reading, but I agree that pathType: Prefix makes more sense as a default. I have pushed a commit with this change, which also adds some comments.
bradrydzewski
approved these changes
May 2, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to the latest version of the drone docker image, 2.11.1
use /healthz for livenessProbe and add readinessProbe
update the chart to be compatibile with newer versions of kubernetes that
require
pathTypefor each specified path in an ingressupdate templates/NOTES.txt and templates/ingress.yaml based on files
generated by running
helm create dronewith helm version 3.8.2