Prepopulate the new-build-form with query params #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently manual drone promotions have to be done by going into a drone build, clicking the kebab menu and clicking Promote.
Then the user has to fill out all of the fields necessary to promote their build. This is pretty user error prone.
We do not want to automate this process completely for the time being (which we can currently already do via cli), we still want a user to have to manually trigger this drone promote when they are ready.
This PR will allow us to generate a drone url such as
/:namespace/:name/:build?target=production&commit=1234¶meters=[{"id":"1","key":"IMAGE_TAG","value":"1234"},{"id":"2","key":"ACTION","value":"deploy"}]. We can then give this generated link to our developers via slack (or anywher else) so they can easily click a link and click Promote without having to manually type out the parameter fields.