Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show the value in the promotion dialog #448

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

nenad
Copy link
Contributor

@nenad nenad commented Nov 30, 2023

This PR shows the value of the parameters in the prompt when promoting. It is confusing when you promote through prepopulating the config #432, but don't see the values of the parameters.

@nenad nenad changed the title Show the value in the promotion dialog feat: Show the value in the promotion dialog Nov 30, 2023
@nenad
Copy link
Contributor Author

nenad commented Dec 1, 2023

@d1wilko This one is related to #432. Would be great if you can take a look, thanks!

Copy link
Contributor

@d1wilko d1wilko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d1wilko d1wilko merged commit 993c372 into drone:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants