Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multi stage approvals #444

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix multi stage approvals #444

merged 1 commit into from
Aug 10, 2023

Conversation

d1wilko
Copy link
Contributor

@d1wilko d1wilko commented Aug 10, 2023

No description provided.

@d1wilko d1wilko requested a review from tphoney August 10, 2023 13:11
@d1wilko d1wilko merged commit 7a768d5 into main Aug 10, 2023
@d1wilko d1wilko deleted the ci-8780 branch August 10, 2023 13:12
tphoney
tphoney reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tphoney tphoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xoxys
Copy link

xoxys commented Aug 11, 2023 •
edited
Loading

@d1wilko What about the handleDeclineClick function at https://github.com/drone/drone-ui/pull/444/files#diff-c46c5904431a32dac3754d9b976f06034e454bc8026432e9aa29e7fb37c26b84R208? It has the same issue and was not fixed.

@d1wilko
Copy link
Contributor Author

d1wilko commented Aug 11, 2023

@xoxys yes good point - will raise another PR - I had a bit of tunnel vision 😳

@xoxys
Copy link

xoxys commented Aug 11, 2023

No worries, thanks!

@d1wilko
Copy link
Contributor Author

d1wilko commented Aug 11, 2023

@xoxys PR is here :) - #446

changes should be in the drone "latest" tag in the next hour or so

@d1wilko d1wilko added the bug label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tphoney tphoney tphoney left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d1wilko @xoxys @tphoney