Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ref should have pullreq instead of pull for gitness #278

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: ref should have pullreq instead of pull for gitness #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88aeebe
fix: ref should have pullreq instead of pull for gitness
abhinav-harness Oct 9, 2023
fd890b4
fix test
abhinav-harness Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scm/driver/harness/pr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func convertPullRequest(src *pr) *scm.PullRequest {
Email: src.Author.Email,
},
Fork: "fork",
Ref: fmt.Sprintf("refs/pull/%d/head", src.Number),
Ref: fmt.Sprintf("refs/pullreq/%d/head", src.Number),
Closed: src.State == "closed",
}
}
Expand Down
2 changes: 1 addition & 1 deletion scm/driver/harness/testdata/pr.json.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"Title": "pull title",
"Body": "pull description",
"Sha": "",
"Ref": "refs/pull/1/head",
"Ref": "refs/pullreq/1/head",
"Source": "bla",
"Target": "main",
"Fork": "fork",
Expand Down