Logging Buffer Overrun Fix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/logger.c
Outdated
| @@ -151,8 +150,9 @@ void logger_task(void *pv_params) { | |||
| if (client_fd < 0) { | |||
| continue; | |||
| } | |||
| build_log_string(&log); | |||
| ssize_t bytes_sent = send(client_fd, &log.message, strlen(log.message), 0); | |||
| char buffer[MAX_LOGGING_LINE_LEN]; | |||
There was a problem hiding this comment.
char buffer[MAX_LOGGING_LINE_LEN] = {0}
Zero initialization for char buffer array if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix buffer overrun bug in the logger modules string building function. The
MAX_LOGGING_LINE_LENGTHmacro is now 1 less than the total supported size to accommodate for the null byte delimiter. The string building function was tested for log lines greater than and less than the maximum length set byMAX_LOGGING_LINE_LENGTHResolutions
.clangdconfiguration file inutilsIssues
closes #13