Adds SITL test infrastructure. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcr3dr
force-pushed
the
tcr-sitltest
branch
7 times, most recently
from
830ec43
to
4839424
Compare
tcr3dr
force-pushed
the
tcr-sitltest
branch
20 times, most recently
from
2b5e469
to
92df258
Compare
tcr3dr
force-pushed
the
tcr-sitltest
branch
14 times, most recently
from
92291cc
to
e12a558
Compare
tcr3dr
changed the title
|
(Rerunning one last time to remove some echo statements.) |
Merged
| print "Read new value of param 'THR_MIN': %s" % v.parameters['THR_MIN'] | ||
|
|
||
| # TODO | ||
| # assert end - start < 1000, 'time to set parameter was %s, over 1s' % (end - start,) |
There was a problem hiding this comment.
Can you add the relevant Asserts here?
There was a problem hiding this comment.
See #12 (my last comment)
|
great place to start, added comments but they are not limiting to merge, great work @tcr3dr, now we need to get better coverage and to start requiring tests on code contributions |
|
👍 |
mrpollo
added a commit
that referenced
this pull request
Jul 14, 2015
Adds SITL test infrastructure.
|
Awesome!
For that you will need a brief guide of how the test infastructure works, how/if it can be set up locally, and information on how you set up your own tests. Is there an issue for that outstanding (I can't see one) and can you write it? |
|
@hamishwillee see #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this only tests a very trivial property check and code around timing #12. This PR would serve as the basis for forthcoming tests.
The test rig itself is wonky, but it's designed to emulate a single-script test as much as possible. In a first-class DKPY module, we'd be using
nosetestsand these would be straightforward to port over.You can run it by running
cd tests; python -m sitl.