Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANNER-707: Workbench "import example dialog": Embed stock example repositories #604

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

mcimbora
Copy link
Contributor

Remove repository initialization from AppSetup

The examples will be moved from https://github.com/droolsjbpm/jbpm-playground to https://github.com/droolsjbpm/kie-wb-playground. This might be a good place to discuss which examples should be included in the workbench by default.

@mcimbora
Copy link
Contributor Author

@cristianonicolai Can you please review the PR and add your thoughts about migration of jbpm-playground examples to https://github.com/droolsjbpm/kie-wb-playground?

@mcimbora
Copy link
Contributor Author

Not complete, adding examples import to project authoring perspective.

@mcimbora
Copy link
Contributor Author

Updated.

@cristianonicolai
Copy link
Contributor

@mcimbora thanks this looks good, my only comment is around the org.kie.demo system property which was useful specially for development to get the example installed once the wb starts. Could we still keep it?
As for the jbpm-playground we need to evaluate which projects still relevant for migration. I believe some are even broken if used on current master.

@mcimbora
Copy link
Contributor Author

@cristianonicolai Sure, I see the point in keeping the property. Once the jBPM examples are included in the jar, there will be no need to fetch them from external location (github). I can implement initial filtering based on tags, so that only relevant examples are imported here. Example repository https://github.com/droolsjbpm/kie-wb-playground currently contains 2 examples (Drools/OptaPlanner), it would be nice to add at least one from jBPM side for now. Can you suggest a working candidate?

@cristianonicolai
Copy link
Contributor

@mcimbora I think we could start with the "evaluation" project. @krisv, @mswiderski wdyt?

@krisv
Copy link
Member

krisv commented Jan 19, 2017

The evaluation one if by far the most important one imho, as it's used as the quickstart example.

…epositories

* Remove repository initialization from AppSetup
@mcimbora
Copy link
Contributor Author

@cristianonicolai Reverted org.kie.demo property usage. I created PR to add evaluation project into kie-wb-playground repository kiegroup/kie-wb-playground#6

@cristianonicolai
Copy link
Contributor

@mcimbora looks good, thanks!

@cristianonicolai cristianonicolai merged commit 2a4fc0c into kiegroup:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants