Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Commit

Permalink
[changes] Comment all build status on diffs
Browse files Browse the repository at this point in the history
Summary: Per email thread, now changesbot will comment for passing builds too

Test Plan: unit tests

Reviewers: kylec, vishal

Reviewed By: vishal

Subscribers: gregprice, changesbot, wwu

Projects: #changes

Differential Revision: https://tails.corp.dropbox.com/D88484
  • Loading branch information
Akhil Ravidas committed Feb 6, 2015
1 parent a62a7d9 commit 0930c27
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions changes/listeners/phabricator_listener.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from flask import current_app

from changes.config import db
from changes.constants import Result
from changes.models import Build, ProjectOption
from changes.utils.http import build_uri

Expand Down Expand Up @@ -85,9 +84,6 @@ def build_finished_handler(build_id, **kwargs):
# Not a diff build
return

if build.result != Result.failed:
return

options = get_options(build.project_id)
if options.get('phabricator.notify', '0') != '1':
return
Expand Down

0 comments on commit 0930c27

Please sign in to comment.