Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Commit

Permalink
Recognize 'allocated' as a waiting state in the UI
Browse files Browse the repository at this point in the history
Summary:
'allocated' is a state between 'pending_allocation' and 'running', and the UI
code should recognize it as indicating a build that is not yet done.
This has the consequence of allowing us to cancel builds stuck in 'allocated'.

Test Plan: None

Reviewers: naphat

Reviewed By: naphat

Subscribers: changesbot, anupc

Tags: #changes_ui

Differential Revision: https://tails.corp.dropbox.com/D225572
  • Loading branch information
kylec1 committed Sep 1, 2016
1 parent 597880e commit 78f0975
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion webapp/display/changes/build_conditions.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export var get_runnable_condition = function(runnable) {
const status = runnable.status ? runnable.status.id : 'finished';
var result = runnable.result.id;

if (status === 'in_progress' || status === 'queued' || status === 'pending_allocation') {
if (status === 'in_progress' || status === 'queued' || status === 'pending_allocation' || status == 'allocated') {
if (runnable.stats && runnable.stats['test_failures']) {
return COND_WAITING_WITH_ERRORS;
}
Expand Down

0 comments on commit 78f0975

Please sign in to comment.