Migrate node v window logic #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate logic from trying with require to checking for existence of window
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 52.19% 52.19%
=======================================
Files 7 7
Lines 730 730
=======================================
Hits 381 381
Misses 349 349
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Brent1LT
approved these changes
Nov 9, 2020
aelawson
approved these changes
Nov 11, 2020
| try { | ||
| fetch = require('node-fetch'); // eslint-disable-line global-require | ||
| } catch (Exception) { | ||
| if (typeof window !== 'undefined') { |
There was a problem hiding this comment.
Should we also check for the existence of fetch? I'm just wondering if there's a case where someone could have have the window object via a bundler, but no fetch and we'd just error out in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate logic from trying with require to checking for existence of window
Checklist
General Contributing
Is This a Code Change?
Validation
npm testpass?npm run buildpass?npm run lintpass?