Add scopes to JS and TS docs #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
==========================================
+ Coverage 65.69% 65.90% +0.21%
==========================================
Files 7 7
Lines 787 792 +5
==========================================
+ Hits 517 522 +5
Misses 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sderickson
changed the title
sderickson
changed the title
6 tasks
|
Looks good to me but please wait until stone has been merged and include the bump of stone version to this diff |
rogebrd
approved these changes
Feb 1, 2022
sderickson
added a commit
to dropbox/stone
that referenced
this pull request
Feb 1, 2022
Add --attribute-comment field to js_client.py and tsd_client.py, like the one added to python_client.py in #262. This is a prerequisite for dropbox/dropbox-sdk-js#891 which adds scopes to the outputted clients for easier reference. Also adds appropriate testing and updates the docstring for the python_client.py, making it more succinct and aligned with the other two.
rogebrd
pushed a commit
that referenced
this pull request
Mar 22, 2022
Update js and ts to include route scopes in their doc strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update js and ts to include route scopes in their doc strings.
Checklist
General Contributing
Is This a Code Change?
Validation
npm testpass?npm run buildpass?npm run lintpass?(seems to error on examples which rely on packages that are not installed?)