Merge pull request #235 from trigun117/master

Fixed gofmt, go_vet, misspell, ineffassign
dropbox · May 12, 2018 · 31879d3 · 31879d3
2 parents 2c3c8cf + c8e39ad
commit 31879d3
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/net2/base_connection_pool_test.go b/net2/base_connection_pool_test.go
@@ -167,7 +167,7 @@ func (s *BaseConnectionPoolSuite) TestRecycleConnections(c *C) {
 	c.Assert(SameConnection(n3, c1), IsFalse)
 	c.Assert(SameConnection(n3, c3), IsTrue)
 
-	n4, err := pool.Get("foo", "bar")
+	n4, _ := pool.Get("foo", "bar")
 	c.Assert(dialer.MaxId(), Equals, 5)
 	c.Assert(n4.RawConn().(*mockConn).Id(), Equals, 5)
 }

diff --git a/net2/http2/simple_pool.go b/net2/http2/simple_pool.go
@@ -112,7 +112,7 @@ func NewSimplePool(addr string, params ConnectionParams) *SimplePool {
 	if params.UseSSL {
 		transport.TLSClientConfig = params.TLSClientConfig
 
-		// Silenty ignore error for now, but probably need to change api
+		// Silently ignore error for now, but probably need to change api
 		// to return error.
 		_ = http2.ConfigureTransport(transport)
 	}

diff --git a/resource_pool/simple_resource_pool_test.go b/resource_pool/simple_resource_pool_test.go
@@ -164,7 +164,7 @@ func (s *SimpleResourcePoolSuite) TestRecycleHandles(c *C) {
 	c.Assert(err, IsNil)
 	CheckSameConnection(c, n3, c3)
 
-	n4, err := pool.Get("bar")
+	n4, _ := pool.Get("bar")
 	c.Assert(dialer.MaxId(), Equals, 5)
 	CheckId(c, n4, 5)
 }

diff --git a/sync2/boundedrwlock.go b/sync2/boundedrwlock.go
@@ -171,7 +171,6 @@ func (rw *BoundedRWLock) processQueue() {
 			}
 		}
 	}
-	return
 }
 
 // A waiting entity, writer or reader.