New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extra date from man page #31

Merged
merged 2 commits into from Mar 11, 2018

Conversation

Projects
None yet
2 participants
@bmwiedemann
Contributor

bmwiedemann commented Jun 20, 2017

to allow for reproducible builds

See https://reproducible-builds.org/ for why this matters.

bmwiedemann added some commits Jun 20, 2017

Drop extra date from man page
to allow for reproducible builds

See https://reproducible-builds.org/ for why this matters.
Allow to override build date
in man page in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Mar 8, 2018

Contributor

Is there anything I can do to help get this simple patch merged?

Contributor

bmwiedemann commented Mar 8, 2018

Is there anything I can do to help get this simple patch merged?

@nipunn1313

This comment has been minimized.

Show comment
Hide comment
@nipunn1313

nipunn1313 Mar 10, 2018

Member

Hi. Thanks for the contribution.
This code looks fine for what it is trying to do.

I am curious why the man page is important for reproducible builds. Generally reproducible builds are talking about the binary output rather than the man pages. Just would like to know the use case to warrant the change. Otherwise, this looks good.

Member

nipunn1313 commented Mar 10, 2018

Hi. Thanks for the contribution.
This code looks fine for what it is trying to do.

I am curious why the man page is important for reproducible builds. Generally reproducible builds are talking about the binary output rather than the man pages. Just would like to know the use case to warrant the change. Otherwise, this looks good.

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Mar 11, 2018

Contributor

We aim to build completely reproducible Linux distributions, so we try to get bit-by-bit reproducible rpm/deb packages and those include man pages.
It is true that it does not contribute much to the security-aspect of reproducible builds, but it helps with other aspects such as

  • giving smaller deltas
  • making diffs easier to read
  • (for openSUSE with OBS) avoiding automatic rebuilds of depending packages
  • saving bandwidth of mirrors and users (by not publishing automatic rebuilds that gave the same binary)

We collected use-cases on https://reproducible-builds.org/docs/buy-in/ but unfortunately the page is a bit hidden.

Contributor

bmwiedemann commented Mar 11, 2018

We aim to build completely reproducible Linux distributions, so we try to get bit-by-bit reproducible rpm/deb packages and those include man pages.
It is true that it does not contribute much to the security-aspect of reproducible builds, but it helps with other aspects such as

  • giving smaller deltas
  • making diffs easier to read
  • (for openSUSE with OBS) avoiding automatic rebuilds of depending packages
  • saving bandwidth of mirrors and users (by not publishing automatic rebuilds that gave the same binary)

We collected use-cases on https://reproducible-builds.org/docs/buy-in/ but unfortunately the page is a bit hidden.

@nipunn1313

This comment has been minimized.

Show comment
Hide comment
@nipunn1313

nipunn1313 Mar 11, 2018

Member

This lgtm. Thank you!

Member

nipunn1313 commented Mar 11, 2018

This lgtm. Thank you!

@nipunn1313 nipunn1313 merged commit 4244be8 into dropbox:master Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment