Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deprecation warning for call to isSet() #99

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

ziegenberg
Copy link
Contributor

Running the command dropbox status prints the following warning message:

/usr/bin/dropbox:614: DeprecationWarning: isSet() is deprecated, use is_set() instead
  if self.stop_event.isSet(): break

because of the use of the deprecated isSet() function call from threading.Event.

This commit uses the new is_set(), which is available since Python 2.6.

Running the command `dropbox status` prints the following warning
message:
	DeprecationWarning: isSet() is deprecated, use is_set() instead
for the line
	  if self.stop_event.isSet(): break
because of the use of the deprecated isSet() call from threading.Event.

This commit uses the new is_set(), which is available since Python 2.6.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
Copy link
Contributor Author

This also occurs for the following calls:

  • dropbox start
  • dropbox stop

I've signed the Dropbox Contributor License Agreement: https://opensource.dropbox.com/cla/

@goffrie goffrie merged commit e5dd947 into dropbox:master Nov 18, 2021
@goffrie
Copy link
Contributor

goffrie commented Nov 18, 2021

Thanks!

@yuriploc
Copy link

yuriploc commented May 20, 2022

Will there be a release with this fix? The last version v2020.03.04 is from 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants