Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external/mypy to 0.790 #179

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

KKawamura1
Copy link
Contributor

All tests in this repo now fail even on the master branch, because pytest.Node(name, parent=...) is deprecated and mypy < 0.790 uses it (See: python/mypy#9263).
So I just bumped up the submodule to version 0.790.

@KKawamura1
Copy link
Contributor Author

Is this repo still alive?
This PR enables us to use tests without the noisy error, having almost no effects to the product (because external/mypy is used only for testing purpose). Only 1 line diff. Please review me if you have time.

Copy link
Contributor

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the slow response!

@JukkaL JukkaL merged commit 9769920 into dropbox:master Jan 8, 2021
brabadu pushed a commit to brabadu/sqlalchemy-stubs that referenced this pull request Jan 15, 2021
Co-authored-by: Keigo Kawamura <kkawamura@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants