Make extra parameters optional for JS/TS backends (#230)

dropbox · May 6, 2021 · 1883c85 · 1883c85
1 parent 0167584
commit 1883c85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/stone/backends/js_types.py b/stone/backends/js_types.py
@@ -220,7 +220,7 @@ def _generate_struct(self, struct_type, extra_parameters=None, nameOverride=None
         for param_name, param_type, param_docstring in extra_parameters:
             param_docstring = ' - %s' % param_docstring if param_docstring else ''
             self.emit_wrapped_text(
-                '@property {%s} %s%s' % (
+                '@property {%s} [%s]%s' % (
                     param_type,
                     param_name,
                     param_docstring,

diff --git a/stone/backends/tsd_types.py b/stone/backends/tsd_types.py
@@ -379,7 +379,8 @@ def _generate_struct_type(self, struct_type, indent_spaces, extra_parameters):
             for param_name, param_type, param_docstring in extra_parameters:
                 if param_docstring:
                     self._emit_tsdoc_header(param_docstring)
-                self.emit('%s: %s;' % (param_name, param_type))
+                # Making all extra args optional parameters
+                self.emit('%s?: %s;' % (param_name, param_type))
 
             for field in struct_type.fields:
                 doc = field.doc