Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extra parameters optional for JS/TS backends #230

Merged
merged 1 commit into from May 6, 2021
Merged

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented May 6, 2021

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #230 (4777f09) into main (0167584) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   51.72%   51.72%           
=======================================
  Files          37       37           
  Lines        8370     8370           
  Branches     1786     1786           
=======================================
  Hits         4329     4329           
  Misses       3727     3727           
  Partials      314      314           
Flag Coverage Δ
unit 51.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/js_types.py 0.00% <ø> (ø)
stone/backends/tsd_types.py 38.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0167584...4777f09. Read the comment docs.

Copy link

@eugeneyche eugeneyche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks!

@rogebrd rogebrd merged commit 1883c85 into main May 6, 2021
@rogebrd rogebrd deleted the optional_extra branch May 6, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants