Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support #288

Closed
samschott opened this issue Nov 21, 2022 · 6 comments
Closed

Python 3.11 support #288

samschott opened this issue Nov 21, 2022 · 6 comments
Labels

Comments

@samschott
Copy link

Describe the bug
Stone's frontend uses the inspect.getargspec method which was deprecated in Python 3.0 and removed in 3.11 (see https://docs.python.org/3.10/library/inspect.html#inspect.getargspec).

argspec = inspect.getargspec(data_type_class.__init__) # noqa: E501 # pylint: disable=deprecated-method,useless-suppression

This results in attribute errors when running stone in Python 3.11.

Versions

  • What version of the Stone are you using? 3.3.1
  • What version of the language are you using? Python 3.11
  • What platform are you using? macOS 13

Additional context
The recommended migration path is to use inspect.getfullargspec as drop-in replacement.

@samschott samschott added the bug label Nov 21, 2022
@greg-db
Copy link
Contributor

greg-db commented Nov 25, 2022

Thanks for the report! I'll ask the team to update that.

@fabaff
Copy link

fabaff commented Jan 24, 2023

For a lot of distributions will stone fail to build due to the missing support for Python 3.11. This will lead to broken dropbox-sdk-python packages down the road.

@greg-db
Copy link
Contributor

greg-db commented Jan 24, 2023

@fabaff Thanks for the note!

@dvzrv
Copy link

dvzrv commented Apr 8, 2023

Hi! We're currently rebuilding all Python packages against Python 3.11 on Arch Linux. This project is now broken.

Can you please replace the use of getargspec() with getfullargspec() (see https://docs.python.org/3/whatsnew/3.11.html) and release a new version? Thanks! :)

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Apr 8, 2023
Switch to PEP517.
Modify sources to be Python 3.11 compatible: dropbox/stone#288

git-svn-id: file:///srv/repos/svn-community/svn@1443016 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Apr 8, 2023
Switch to PEP517.
Modify sources to be Python 3.11 compatible: dropbox/stone#288

git-svn-id: file:///srv/repos/svn-community/svn@1443016 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@greg-db
Copy link
Contributor

greg-db commented Apr 10, 2023

@dvzrv Thanks for the feedback! This is open with the team. I'll follow up here with any updates.

@wfraser
Copy link
Member

wfraser commented Apr 22, 2024

fixed in #299

@wfraser wfraser closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants