Version compatible inspect handling for class parameters #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getargspec` was deprecated in Python 3.0, but finally removed in Python 3.11. For reference: Pylons/pyramid#3688 That seems like a valid amount of time. We can do our best effort and if the user is running a Python version that still has `getargspec` use that, but if they have `getfullargspec` which is available in Python 3.11, we can use that.
Closed
include `isclass`
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 52.02% 52.02% -0.01%
==========================================
Files 37 37
Lines 8458 8462 +4
Branches 1810 1810
==========================================
+ Hits 4400 4402 +2
- Misses 3741 3743 +2
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Fixes #288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getargspecwas deprecated in Python 3.0, but finally removed in Python 3.11. For reference: Pylons/pyramid#3688That seems like a valid amount of time for us to have fixed it.
We can do our best effort and if the user is running a Python version that still has
getargspecuse that, but if they havegetfullargspecwhich is available in Python 3.11, we can use that.Checklist
General Contributing
Is This a Code Change?
Validation
tox?