Skip to content

Commit

Permalink
Add deprecation notices related to Jetty 12 (#8061)
Browse files Browse the repository at this point in the history
In the `AbstractServerFactory` of the `release/5.0.x` branch some method signatures had to be updated to work properly with Jetty 12.
  • Loading branch information
zUniQueX committed Dec 18, 2023
1 parent fee8a56 commit ca74a01
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,12 @@ protected SetUIDListener buildSetUIDListener() {
return listener;
}

/**
* @deprecated Jetty 12 removes the {@link RequestLogHandler}. Therefore, the signature of this method will be
* changed to
* {@code void addRequestLog(Server server, String name, MutableServletContextHandler servletContextHandler)}.
*/
@Deprecated
protected Handler addRequestLog(Server server, Handler handler, String name) {
if (getRequestLogFactory().isEnabled()) {
final RequestLogHandler requestLogHandler = new RequestLogHandler();
Expand All @@ -765,6 +771,12 @@ protected Handler addRequestLog(Server server, Handler handler, String name) {
return handler;
}

/**
* @deprecated Graceful shutdown isn't performed with the {@link StatisticsHandler} in Jetty 12 anymore and metrics
* are collected with {@link InstrumentedHandler InstrumentedHandlers}. Will be replaced by a method with signature
* {@code Handler addGracefulHandler(Handler handler)}
*/
@Deprecated
protected Handler addStatsHandler(Handler handler) {
// Graceful shutdown is implemented via the statistics handler,
// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=420142
Expand Down

0 comments on commit ca74a01

Please sign in to comment.