Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit 5 support in dropwizard-testing #1944

Closed
ramsrib opened this issue Mar 1, 2017 · 4 comments
Closed

JUnit 5 support in dropwizard-testing #1944

ramsrib opened this issue Mar 1, 2017 · 4 comments

Comments

@ramsrib
Copy link

ramsrib commented Mar 1, 2017

I think dropwizard-testing module doesn't support JUnit 5 yet. Mainly the rules/class rules written in Junit 4 (in dropwizard-testing) doesn't work in Junit 5.

FYI, Frameworks like Mockito now officially supports JUnit 5.

@nickbabcock
Copy link
Contributor

Thanks for filing a issue so we can track this improvement. I took a quick look at the migration guide. And since junit5 will support ExternalResource, it looks like the only code in dropwizard-testing that has to change (or be complemented) is ResourceTestRule which implements TestRule

@ramsrib
Copy link
Author

ramsrib commented Nov 13, 2017

Since Junit 5 has been released. It would be nice if someone updates the dropwizard testing documentation with JUnit 5 specific example.

@arteam
Copy link
Member

arteam commented Nov 23, 2017

Closed via #2166

@arteam arteam closed this as completed Nov 23, 2017
@krupeshf
Copy link

@ramsrib where you able to test using JUnit5?
As you mentioned, the documentation still points to JUnit4
https://www.dropwizard.io/1.3.9/docs/manual/testing.html#id2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants