Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bootstrap logging json format? #2250

Closed
mattnelson opened this issue Jan 21, 2018 · 1 comment
Closed

Support bootstrap logging json format? #2250

mattnelson opened this issue Jan 21, 2018 · 1 comment

Comments

@mattnelson
Copy link
Contributor

Pulled in 1.3.0-rc4 to experiment with json logging before the release. Bootstrap logging[1] defaults to a traditional format. Should there be an option to flex bootstrap logging to json? In the use cases that all logs are sent to log processors (splunk, elk, etc..) they may not be configured to recognize the non-json log event.

22:10:37.601 [main] INFO org.eclipse.jetty.util.log - Logging initialized @414ms to org.eclipse.jetty.util.log.Slf4jLog
{"level":"INFO","logger":"io.dropwizard.server.DefaultServerFactory","thread":"main","message":"Registering jersey handler with root path prefix: /","timestamp":"2018-01-21T22:10:40.131Z"}

[1] https://github.com/dropwizard/dropwizard/blob/v1.3.0-rc4/dropwizard-logging/src/main/java/io/dropwizard/logging/BootstrapLogging.java

@nickbabcock
Copy link
Contributor

Makes sense. While users can already override the bootstrap logging in their application classes, it does seem reasonable to provide convenience function for JSON log apps. The only (minor) concern I have is that since bootstrapping is done in code there could be a mismatch where the developer bootstraps as JSON, but config log format is traditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants