Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configPath in DropwizardTestSupport could only be file #1830

Closed
wants to merge 1 commit into from
Closed

Fix configPath in DropwizardTestSupport could only be file #1830

wants to merge 1 commit into from

Conversation

aeolus
Copy link

@aeolus aeolus commented Nov 16, 2016 •
edited

trying to fix #1709

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 31081f4 on aeolus:jar-url-test-config into * on dropwizard:master*.

@aeolus
Fix dropwizard#1709
5c33ad3 
choose proper configurationSourceProvider for configPath in DropwizardTestSupport
@aeolus aeolus changed the title this commit tries to fix #1709 Fix #1709 Nov 17, 2016
@aeolus aeolus changed the title Fix #1709 Fix configPath in DropwizardTestSupport could only be file Nov 17, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 81.933% when pulling 5c33ad3 on aeolus:jar-url-test-config into 37bbdd1 on dropwizard:master.

@jplock jplock added the bug label Nov 18, 2016
@jplock jplock added this to the 1.1.0 milestone Nov 18, 2016
@arteam
Copy link
Member

arteam commented Nov 18, 2016

Wouldn't it to be better to expose configurationSourceProvider as a field for DropwizardTestSupport?
Users who load resources from URLs will be able to set UrlConfigurationSourceProvider explicitly in a DropwizardTestSupport constructor.

@jplock jplock removed this from the 1.1.0 milestone Feb 13, 2017
joschi added a commit that referenced this pull request Mar 3, 2019
@joschi
Improve Dropwizard test support
dd69ecf 
* Allow specifying ConfigurationSourceProvider in DropwizardTestSupport, DropwizardAppRule, and DropwizardAppExtension
* Mark constructors with `Optional<String>` for configuration file as deprecated in favor of nullable versions
  * See https://rules.sonarsource.com/java/RSPEC-3553
* Better exceptions when initializing the test application fails
* Clean up tests and remove redundant test applications

Closes #1709
Closes #1830
@joschi joschi mentioned this pull request Mar 3, 2019
Merged
@joschi joschi closed this in #2673 Mar 3, 2019
joschi added a commit that referenced this pull request Mar 3, 2019
@joschi
Improve Dropwizard test support (#2673)
86abeb0 
* Allow specifying ConfigurationSourceProvider in DropwizardTestSupport, DropwizardAppRule, and DropwizardAppExtension
* Mark constructors with `Optional<String>` for configuration file as deprecated in favor of nullable versions
  * See https://rules.sonarsource.com/java/RSPEC-3553
* Better exceptions when initializing the test application fails
* Clean up tests and remove redundant test applications

Closes #1709
Closes #1830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropwizardTestSupport not compatible with Failsafe 2.19
4 participants
@aeolus @coveralls @arteam @jplock