Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set up SO_LINGER for the HTTP connector #2176

Merged
merged 1 commit into from Oct 17, 2017
Merged

Correctly set up SO_LINGER for the HTTP connector #2176

merged 1 commit into from Oct 17, 2017

Commits on Oct 17, 2017

  1. Correctly set up SO_LINGER for the HTTP connector 

    Jetty's `ServerConnector` accepts `soLingerTime` in milliseconds, rather
than in seconds as `Socket.setSoLinger` does [1]. Dropwizard on the other
hand after parsing the YML configuration and extracting the `soLingerTime` parameter
passes it to Jetty in seconds. As a result, the configuration gets really
confusing for users, because the configuration value is more than the actual
SO_LINGER timeout by 1000 times.

The fix is to pass the configuration value to Jetty's `ServerConnector`
in milliseconds.

[1]: http://www.eclipse.org/jetty/documentation/9.4.x/configuring-connectors.html
    @arteam
    arteam committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    32f9256 View commit details
    Browse the repository at this point in the history