Use InstrumentedQueuedThreadPool for admin endpoint #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joschi Can you please have a look ? |
|
Is there a way to make this optional/configurable? |
|
To be honest I didn't consider it, as I haven't seen any downsides of using it, but I guess it could be made configurable by some additional boolean flag, i.e. |
|
I don't think it's needed. The overhead of instrumenting should be fairly small to warrant adding an additional configuration option. |
|
The biggest concern for me is the increase of reported metrics by default for a Dropwizard app. |
|
|
|
But, my opinion, 4 additional metrics should not be a big problem. They are quite useful metrics, especially for applications with a lot of admin tasks. |
|
@patrox Thank you for the contribution! |
sankate
pushed a commit
to sankate/dropwizard
that referenced
this pull request
Nov 21, 2017
aaanders
pushed a commit
to aaanders/dropwizard
that referenced
this pull request
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to monitor the usage of the thread pool which is used to handle the requests landing at admin endpoint.
Closes #2179.