Make sure test Jersey test client uses Dropwizard's ObjectMapper #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Jersey client produced by `DropwizardAppRule` uses a simple Jackson's ObjectMapper. This could be an issue when a serialized/deserialized entity requires additional modules (Java 8 `Optional`, `DateTime`, `ParamaterNames` module etc...), which are added automatically in Dropwizard's `ÒbjectMapper` and used for the server side. A fix is too prodouce a client with a Jackson binder which uses the `ObjectMapper` instance from the test environment.
jplock
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently the Jersey client produced by
DropwizardAppRuleuses a simple Jackson's ObjectMapper. This could be an issue when a serialized/deserialized entity requires additional modules (Java 8Optional,DateTime,ParamaterNamesmodule etc...), which areadded automatically in Dropwizard's
ÒbjectMapperand used for the server side.Solution:
Produce a client with a Jackson binder which uses the
ObjectMapperinstance from the test environment.Result:
Less surprises for users and discrepancies between the client and server JSON serialization.