Extend from AbstractHandlerContainer instead of AbstractHandler #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnelson
reviewed
Aug 22, 2018
|
|
||
| @Override | ||
| public Handler[] getHandlers() { | ||
| return handlers.keySet().stream().map(key -> handlers.get(key)).toArray(Handler[]::new); |
There was a problem hiding this comment.
Changing Trie to ArrayTernaryTrie introduces entrySet which will eliminate the lookup in a loop.
private final ArrayTernaryTrie<Handler> handlers;
handlers.entrySet().stream().map(Map.Entry::getValue).toArray(Handler[]::new);
|
Thanks @mattnelson, fixed! |
|
AppVeyor failed with: |
|
Would it be possible to have this included in the 1.3.6 release? |
joschi
pushed a commit
to joschi/dropwizard-1.3
that referenced
this pull request
Aug 16, 2020
…wizard#2460) (cherry picked from commit 5a78323)
joschi
pushed a commit
to joschi/dropwizard-1.3
that referenced
this pull request
Aug 16, 2020
…wizard#2460) (cherry picked from commit 5a78323)
joschi
pushed a commit
to joschi/dropwizard-1.3
that referenced
this pull request
Aug 16, 2020
…wizard#2460) (cherry picked from commit 5a78323)
joschi
pushed a commit
that referenced
this pull request
Aug 18, 2020
(cherry picked from commit 5a78323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2455