Migrate tests to JUnit 5.4.0 #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
junit5-migration
branch
5 times, most recently
from
b9b334b
to
2540701
Compare
nickbabcock
reviewed
Sep 16, 2018
dropwizard-core/src/test/java/io/dropwizard/setup/BootstrapTest.java
Outdated
Show resolved
Hide resolved
nickbabcock
reviewed
Sep 16, 2018
nickbabcock
reviewed
Sep 16, 2018
dropwizard-e2e/src/test/java/com/example/badlog/BadLogTest.java
Outdated
Show resolved
Hide resolved
nickbabcock
reviewed
Sep 16, 2018
arteam
force-pushed
the
junit5-migration
branch
2 times, most recently
from
42f451b
to
674cf72
Compare
|
You should use higher version |
joschi
force-pushed
the
junit5-migration
branch
from
674cf72
to
f659416
Compare
joschi
force-pushed
the
junit5-migration
branch
2 times, most recently
from
6309610
to
f5a675c
Compare
|
Is there a way to re-run the tests on Appveyor? |
joschi
force-pushed
the
junit5-migration
branch
6 times, most recently
from
6d8177a
to
ddd435e
Compare
* CustomRequestLogPatternIntegrationTest * RequestLogPatternIntegrationTest Example exception (shortened): ERROR [2019-03-02 10:38:12,736] org.junit.jupiter.engine.execution.JupiterEngineExecutionContext: Caught exception while closing extension context: org.junit.jupiter.engine.descriptor.MethodExtensionContext@72bca894 java.io.IOException: Failed to delete temp directory C:\Users\appveyor\AppData\Local\Temp\1\junit6846106039914940147. The following paths could not be deleted (see suppressed exceptions for details): , example-new-app-not-additive.log, example-new-app.log, example.log at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:206) at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:167) Suppressed: java.nio.file.DirectoryNotEmptyException: C:\Users\appveyor\AppData\Local\Temp\1\junit6846106039914940147 at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath$1.deleteAndContinue(TempDirectory.java:187) at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath$1.postVisitDirectory(TempDirectory.java:182) at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath$1.postVisitDirectory(TempDirectory.java:173) at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.deleteAllFilesAndDirectories(TempDirectory.java:173) at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:165) ... 44 common frames omitted Suppressed: java.nio.file.FileSystemException: C:\Users\appveyor\AppData\Local\Temp\1\junit6846106039914940147\example.log: The process cannot access the file because it is being used by another process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit5 has been slowly getting among the community over the past years and it looks like stable enough for us to migrate.