DropwizardTestSupport should only override the app's ConfigurationSou… #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbabcock
reviewed
Apr 5, 2019
...src/test/java/io/dropwizard/testing/DropwizardTestSupportWithResourceConfigProviderTest.java
Outdated
Show resolved
Hide resolved
natalie-zamani
force-pushed
the
fix-test-support-config-source-provider-overriding-behavior
branch
from
aaa8834
to
9a072be
Compare
…rceProvider if one is explicitly provided in a constructor (dropwizard#2719)
natalie-zamani
force-pushed
the
fix-test-support-config-source-provider-overriding-behavior
branch
from
9a072be
to
8dcf226
Compare
|
@nickbabcock Anything else to consider with this one? Or does this approach seem tenable? |
nickbabcock
approved these changes
Apr 5, 2019
natalie-zamani
deleted the
fix-test-support-config-source-provider-overriding-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rceProvider if one is explicitly provided in a constructor (#2719)
Problem:
See #2719
Solution:
Made
DropwizardTestSupportsConfigurationSourceProvideroverride nullable, and only override the app'sConfigurationSourceProviderif one is explicitly provided via a constructor.Result:
This will fix the behavior of
DropwizardTestSupportin tests when the app sets a differentConfigurationSourceProvider.