allow overriding request executor #2959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Similar to #2958, this is a further improvement to allow passing in a customised RequestExecutor so that we can additional metrics regarding cache hit and cache miss.
Solution:
Instead of fixed
new InstrumentedHttpRequestExecutor()
, allow the subclasses to provide their own implementation ofHttpRequestExecutor
Result:
N.A.