Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3053
Problem:
As described in the Issue #3053, the Saying validation annotation doesn't entirely make sense.
Solution:
I have removed the
@Max
annotation from theSaying
class and removed the@Valid
annotation from the resource. To still show the annotation in use I have modified thePerson
class in core and the people resource to reflect that. I have also added a test to show the validation in action on the resource.Result:
I know adding age to a person isn't a particularly sensible thing to do normally, but it is a good way to show basic use of these annotations in action. Feedback on the test would also be appreciated, without an exception mapper I'm not sure what to test for - other than what I have implemented.