Address SonarCloud issues #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonarCloud picked this one up - Person#getId returns a long, so there isn't really a decent test we can do here.
Remove spurious import of StandardCharsets and extraneous exception declarations.
…it gets run The default surefire configuration doesn't execute tests in static inner classes. We can't easily make the inner classes non-static because of the parameterized tests, so just split the test class into two classes instead.
We can use AssertJ's built-in Exception handling assertions instead of open-coding a try-catch.
joschi
approved these changes
Jan 24, 2021
joschi
pushed a commit
that referenced
this pull request
Jan 26, 2021
- Remove the assertions which can't fail in dropwizard-example. - Split `ZipExceptionHandlingInputStreamTest` into two test classes. Since one of the inner classes was a parameterised test, it needed a static field and so the alternative was to reconfigure surefire. That seemed like a bit of a heavy-handed option so I just split the test up instead. I changed the `@Test` annotations to `@ParameterizedTest` as suggested by IntelliJ. (cherry picked from commit 7d6d94a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Sonar is grumbling about a few things. Some aren't so valid and others I'm not too sure about, but the ones addressed by this PR do seem to be genuine:
These two:
https://sonarcloud.io/project/issues?id=dropwizard_dropwizard&issues=AXUXdIJdpBosHuY9-PuM&open=AXUXdIJdpBosHuY9-PuM
https://sonarcloud.io/project/issues?id=dropwizard_dropwizard&issues=AXUXdIIWpBosHuY9-Ptj&open=AXUXdIIWpBosHuY9-Ptj
relate to tests in
dropwizard-exampleasserting that alongis notnull, which isn't really proving anything.These two:
https://sonarcloud.io/project/issues?id=dropwizard_dropwizard&issues=AXUXdIWFpBosHuY9-Pyx&open=AXUXdIWFpBosHuY9-Pyx
https://sonarcloud.io/project/issues?id=dropwizard_dropwizard&issues=AXUXdIWFpBosHuY9-Py7&open=AXUXdIWFpBosHuY9-Py7
relate to the
@Nestedannotation being used indropwizard-jetty'sZipExceptionHandlingInputStreamTest. This actually exposes the fact that these tests aren't being run because by default, surefire doesn't run tests in static inner classes!Solution:
Remove the assertions which can't fail in
dropwizard-example.Split
ZipExceptionHandlingInputStreamTestinto two test classes. Since one of the inner classes was a parameterised test, it needed a static field and so the alternative was to reconfigure surefire. That seemed like a bit of a heavy-handed option so I just split the test up instead. I changed the@Testannotations to@ParameterizedTestas suggested by IntelliJ - not 100% sure that was the right thing to do, but it knows Java better than I.Whilst we're in there, tidy up the assertions to use
assertThatExceptionOfTypeinstead of open-coding a try-catch.Result:
Fewer Sonar errors, more tests being run, test code is a bit simpler.