Make jUnit 4 test methods public #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least I believe the PR message is true - unless these tests are running in some sort of strange junit4-in-jupiter mode that I didn't know existed? |
This is a regression from f17aea0 - not all tests are jUnit 5. jUnit 4 test methods should be made public.
rhowe
force-pushed
the
public-junit4-tests
branch
from
2614367
to
a22e419
Compare
arteam
approved these changes
Feb 28, 2021
|
Thanks for following up on this! |
joschi
pushed a commit
that referenced
this pull request
Mar 4, 2021
This is a regression from f17aea0 - not all tests are jUnit 5. jUnit 4 test methods should be made public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from f17aea0 - not all tests are jUnit 5. jUnit 4 test methods should be made public.