Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix an unstable test in the class
TlsSocketAppenderFactoryTest
.Problem:
loggingFactory.reset()
must be called in order to receive the logged messages because it closes theOutputStream
of theSocket
in the appender. The relevant call isdetachAndStopAllAppenders()
which eventually closes the appender but maybe discards messages to be written asynchronously.If the appender is closed before all asynchronously messages are written, the test fails. This leads to a race condition between writing the log messages and closing the appender.
Solution:
loggingFactory.stop()
will attempt to flush outstanding log messages, so the messages should all be written when the appender eventually gets stopped.