Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests to different optional behaviour of Jersey 2.38 #6405

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

joschi
Copy link
Member

@joschi joschi commented Dec 30, 2022

Follow-up for #6380

The Optional handling was changed in eclipse-ee4j/jersey#5194. An Optional will be empty, if an empty string is provided for a parameter. This partially restores behavior previous to Jersey 2.35: here the new status is 200 again, but the default value isn't processed. The Optional is empty.

(cherry picked from commit 6af3f10)

@joschi joschi added task dependencies Pull requests that update a dependency file labels Dec 30, 2022
@joschi joschi added this to the 3.0.0 milestone Dec 30, 2022
@joschi joschi requested a review from a team as a code owner December 30, 2022 20:54
@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2022

@joschi joschi changed the title Adjust tests to different optional behaviour of Jersey 2.38 (#6404) Adjust tests to different optional behaviour of Jersey 2.38 Dec 30, 2022
@joschi joschi enabled auto-merge (squash) December 30, 2022 20:55
@joschi joschi disabled auto-merge December 30, 2022 20:55
@joschi joschi enabled auto-merge (squash) December 30, 2022 20:55
Follow-up for #6380

The `Optional` handling was changed in eclipse-ee4j/jersey#5194. An `Optional` will be empty, if an empty string is provided for a parameter. This partially restores behavior previous to Jersey 2.35: [here](38277c4#diff-4d6c6806a2239cf8f9414414c0cb9602f9cb87eb55460aa762ce92d94f85417aL1205-L1206) the new status is 200 again, but the default value isn't processed. The `Optional` is empty.

(cherry picked from commit 6af3f10)
@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joschi joschi merged commit 2d21157 into release/3.0.x Dec 30, 2022
@joschi joschi deleted the jersey-2.38-tests-3.0.x branch December 30, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants