Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jakarta EE 10 components #7962

Closed
wants to merge 7 commits into from

Conversation

zUniQueX
Copy link
Member

@zUniQueX zUniQueX commented Dec 1, 2023

This PR updates the dependencies to Jakarta EE 10 components and does necessary migrations.

The main change of this PR is the upgrade to Jetty 12, which removes the servlet classes from the Jetty core.

@zUniQueX zUniQueX added the task label Dec 1, 2023
@zUniQueX zUniQueX added this to the 5.0.0 milestone Dec 1, 2023
@zUniQueX zUniQueX self-assigned this Dec 1, 2023
@zUniQueX zUniQueX requested a review from a team as a code owner December 1, 2023 19:31
@zUniQueX
Copy link
Member Author

zUniQueX commented Dec 2, 2023

@dropwizard/committers Supporting the logback request log gets really tricky with Jetty 12. I've introduced a workaround here but that is neither clean nor efficient. Should we think of dropping support for the logback request log in favor of the Jetty CustomRequestLog?

@joschi
Copy link
Member

joschi commented Dec 14, 2023

Should we think of dropping support for the logback request log in favor of the Jetty CustomRequestLog?

Yes, let's see how this would look like.

Is there anything we could ask the Logback maintainer for which would enable us to avoid the migration?

Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ❤️

I've resolved the merge conflicts in #8038 but feel free to update this PR and merge it if auto-merge of the new PR fails. 😅

@joschi joschi closed this Dec 14, 2023
@zUniQueX zUniQueX deleted the ee-10 branch December 15, 2023 06:17
@zUniQueX
Copy link
Member Author

Thanks for the review 👍

Is there anything we could ask the Logback maintainer for which would enable us to avoid the migration?

I don't think so. Logback depends on the servlet api and the servlet classes aren't available in the request log stage (hence the LogbackAccessRequestLogAwareHandler). My workaround probably cannot be ported to logback and won't be introduced.

Logback access is broken for a few versions now and I don't think it'll be maintained well in the future either. This would be a good moment to drop support IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants