-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Jakarta EE 10 components #7962
Conversation
@dropwizard/committers Supporting the logback request log gets really tricky with Jetty 12. I've introduced a workaround here but that is neither clean nor efficient. Should we think of dropping support for the logback request log in favor of the Jetty |
69e3057
to
54b7ec7
Compare
Yes, let's see how this would look like. Is there anything we could ask the Logback maintainer for which would enable us to avoid the migration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. ❤️
I've resolved the merge conflicts in #8038 but feel free to update this PR and merge it if auto-merge of the new PR fails. 😅
Thanks for the review 👍
I don't think so. Logback depends on the servlet api and the servlet classes aren't available in the request log stage (hence the Logback access is broken for a few versions now and I don't think it'll be maintained well in the future either. This would be a good moment to drop support IMHO. |
This PR updates the dependencies to Jakarta EE 10 components and does necessary migrations.
The main change of this PR is the upgrade to Jetty 12, which removes the servlet classes from the Jetty core.