Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notices #8061

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add deprecation notices #8061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions dropwizard-core/src/main/java/io/dropwizard/core/server/AbstractServerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,12 @@ protected SetUIDListener buildSetUIDListener() {
return listener;
}

/**
* @deprecated Jetty 12 removes the {@link RequestLogHandler}. Therefore, the signature of this method will be
* changed to
* {@code void addRequestLog(Server server, String name, MutableServletContextHandler servletContextHandler)}.
*/
@Deprecated
protected Handler addRequestLog(Server server, Handler handler, String name) {
if (getRequestLogFactory().isEnabled()) {
final RequestLogHandler requestLogHandler = new RequestLogHandler();
Expand All @@ -765,6 +771,12 @@ protected Handler addRequestLog(Server server, Handler handler, String name) {
return handler;
}

/**
* @deprecated Graceful shutdown isn't performed with the {@link StatisticsHandler} in Jetty 12 anymore and metrics
* are collected with {@link InstrumentedHandler InstrumentedHandlers}. Will be replaced by a method with signature
* {@code Handler addGracefulHandler(Handler handler)}
*/
@Deprecated
protected Handler addStatsHandler(Handler handler) {
// Graceful shutdown is implemented via the statistics handler,
// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=420142
Expand Down