/ metrics Public
Add CollectionUsage.getUsed() to MemoryPool gauges #786
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
For monitoring memory usage, the memory used gauge is not very suitable to put automated analysis on, because it can be varying wildly. A better choice for these situations would be the JMX metric of the memory that's still in use after the last garbage collection. This gives a more accurate indication of retained memory, without varying short lived object allocation.
This pull requests adds it as a gauge to the memory pool gauge set with postfix "used-after-gc".
The rest of the CollectionUsage methods (init, committed, max) are of no value, since they're basically identical to the normal MemoryUsage of the same pool, and are therefore not included.