New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CollectionUsage.getUsed() to MemoryPool gauges #786

Merged
merged 2 commits into from Apr 24, 2015

Conversation

Projects
None yet
2 participants
@Menthalion

Menthalion commented Apr 24, 2015

For monitoring memory usage, the memory used gauge is not very suitable to put automated analysis on, because it can be varying wildly. A better choice for these situations would be the JMX metric of the memory that's still in use after the last garbage collection. This gives a more accurate indication of retained memory, without varying short lived object allocation.

This pull requests adds it as a gauge to the memory pool gauge set with postfix "used-after-gc".

The rest of the CollectionUsage methods (init, committed, max) are of no value, since they're basically identical to the normal MemoryUsage of the same pool, and are therefore not included.

ryantenney added a commit that referenced this pull request Apr 24, 2015

Merge pull request #786 from Menthalion/used-aftergc
Add CollectionUsage.getUsed() to MemoryPool gauges

@ryantenney ryantenney merged commit 86f4974 into dropwizard:master Apr 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment