Add support for async servlet to metrics-servlet #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requests timer and the activeRequests counter now properly observe the entire processing time. Use meters separate from the response code meters for timeouts and errors since the code isn't representative (i.e. 200) for these situations.
ryantenney
added a commit
that referenced
this pull request
Jun 12, 2015
Add support for async servlet to metrics-servlet
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Proposition for issue #795.
The requests timer and the activeRequests counter now properly observe the entire processing time. Use meters separate from the response code meters for timeouts and errors since the code isn't representative (i.e. 200) for these situations.